Button: added replace on radio name to escape quotes. Fixed #7505 - Butt... #754

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
Contributor

DaleKocian commented Oct 15, 2012

...on: Buttonset not applied to radio group with quotation/apostrophe in name

Button: added replace on radio name to escape quotes. Fixed #7505 - B…
…utton: Buttonset not applied to radio group with quotation/apostrophe in name
Owner

jzaefferer commented Oct 16, 2012

We need a more general escaping that isn't specific to single characters. Probably overlaps with what tabs is already doing:

_sanitizeSelector: function( hash ) {

Owner

jzaefferer commented Oct 22, 2012

Duplicate of #401 :sadpanda:

@jzaefferer jzaefferer closed this Oct 22, 2012

Owner

jzaefferer commented Oct 22, 2012

Kind of. Leaving this open for now.

@jzaefferer jzaefferer reopened this Oct 22, 2012

Owner

gnarf commented Oct 25, 2012

I like this better than #401 since it only escapes the ' - Gonna close that old one

Member

mikesherov commented Nov 9, 2012

@gnarf37, @jzaefferer what's the status of this pull request? And it also needs tests if it's going to land, right?

Owner

jzaefferer commented Nov 15, 2012

@DaleKocian could you add a unit test for this? Also, the replace call should happen inside the if ( name ) so that it doesn't throw up when there is no name property.

Member

mikesherov commented Nov 16, 2012

@jzaefferer, besides a unit test, we'd also want to generalize the solution using

_sanitizeSelector: function( hash ) {
, right?

Owner

scottgonzalez commented Nov 16, 2012

I'm fine moving that method to core if it makes sense.

Owner

jzaefferer commented Nov 17, 2012

No we don't, according to @gnarf37 commenting here: #401 (comment)

Member

mikesherov commented Nov 17, 2012

Ok, thanks @jzaefferer

Member

mikesherov commented Nov 19, 2012

Landed something similar in cc7df71

@mikesherov mikesherov closed this Nov 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment