Button: Fixing handling of the disabled options on refresh method calls.... #832
Conversation
…ls. Fixed #8828 - Button: Refresh does not re-enable disabled button.
|
I think it'd be better to check for elements which support the |
|
I guess the logical or was the problem before though, so keep the ternary, but change to checking against input/button? |
…arbitrary elements that do not support the disabled property (div, span, etc).
|
@scottgonzalez Good call. I flipped the call and added a test with a |
| @@ -284,7 +284,9 @@ $.widget( "ui.button", { | |||
| }, | |||
|
|
|||
| refresh: function() { | |||
| var isDisabled = this.element.is( ":disabled" ) || this.element.hasClass( "ui-button-disabled" ); | |||
| //See #8237 & #8828 | |||
There was a problem hiding this comment.
being super picky here, but comments should have a space: // See #8237 & #8828
|
besides my minor not, which I can fix while merging, this looks good to me. Let me know @scottgonzalez, and I can land this. |
|
Thanks, landed in 93abe02 |
... Fixed #8828 - Button: Refresh does not re-enable disabled button.
See http://bugs.jqueryui.com/ticket/8828.