New download dialog progressbar demo #872

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Owner

kborchers commented Dec 30, 2012

No description provided.

@scottgonzalez scottgonzalez commented on an outdated diff Jan 1, 2013

demos/progressbar/download.html
+<head>
+ <meta charset="utf-8">
+ <title>jQuery UI Progressbar - Download Dialog</title>
+ <link rel="stylesheet" href="../../themes/base/jquery.ui.all.css">
+ <script src="../../jquery-1.8.3.js"></script>
+ <script src="../../ui/jquery.ui.core.js"></script>
+ <script src="../../ui/jquery.ui.widget.js"></script>
+ <script src="../../ui/jquery.ui.progressbar.js"></script>
+ <script src="../../ui/jquery.ui.button.js"></script>
+ <script src="../../ui/jquery.ui.position.js"></script>
+ <script src="../../ui/jquery.ui.dialog.js"></script>
+ <link rel="stylesheet" href="../demos.css">
+ <script>
+ $(function() {
+ var progressbar = $( "#progressbar" ),
+ progressLabel = $( ".progress-label" ),
@scottgonzalez

scottgonzalez Jan 1, 2013

Owner

progressbar.find( ".progress-label" )

@scottgonzalez scottgonzalez commented on an outdated diff Jan 1, 2013

demos/progressbar/download.html
+ $( this ).button( "option", {
+ disabled: true,
+ label: "Downloading..."
+ });
+ dialog.dialog( "open" );
+ });
+
+ progressbar.progressbar({
+ value: false,
+ change: function() {
+ progressLabel.text( progressbar.progressbar( "value" ) + "%" );
+ },
+ complete: function() {
+ progressLabel
+ .prependTo( "#progressbar" )
+ .css({
@scottgonzalez

scottgonzalez Jan 1, 2013

Owner

Use a class.

Owner

scottgonzalez commented Jan 1, 2013

I actually find the moving label kind of distracting. What do you think about just moving the label outside of the progressbar, either above or below it?

Owner

scottgonzalez commented Jan 1, 2013

I'm also not a fan of a non-movable, non-closable dialog.

Owner

kborchers commented Jan 2, 2013

I can move the label out, no problem. I actually meant to add a "Cancel Download" button which would effectively just close the dialog but didn't feel like the "X" button made sense. I'll add that button and make it movable.

Owner

kborchers commented Jan 4, 2013

@scottgonzalez let me know what you think of those updates

Owner

jzaefferer commented Jan 10, 2013

  • Add new file to index.html
  • Move focus to "Done" button when replacing the Cancel Download button
  • Progress got stuck at 99% twice, maybe need to check for <= on line 64
  • Reenable the button before closing the dialog, so that focus can move back
Owner

jzaefferer commented Apr 29, 2013

@kborchers ping. Can you address those four points above?

Owner

kborchers commented Apr 29, 2013

@jzaefferer Yep, I should have time to do that tonight. Sorry, this must have slipped by me and I forgot about it.

Owner

kborchers commented Apr 30, 2013

Replacing this PR with #970 since this PR was done from my master branch like a n00b :-/

kborchers closed this Apr 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment