Skip to content

jQuery UI.com mobile full-width fix. #201

Closed
wants to merge 2 commits into from

3 participants

@kleinmaetschke

Fixing sidebar issue that makes jQueryUI.com not make full-width on mobile devices.

@jzaefferer
jQuery Foundation member

I tried this with the iOS simulator (retina iPhone), still broken: http://bassistance.de/i/ce8d81.png

@kleinmaetschke

@jzaefferer Can you screenshot what you're seeing where the Dev-links sidebar is, further down the page?

@jzaefferer
jQuery Foundation member

Well, the sidebar looks better, but the actual issue is still there: http://bassistance.de/i/d53363.png

Without your changes: http://bassistance.de/i/56947e.png

@kleinmaetschke

@jzaefferer Thanks. Either I didn't properly curtail #dev-links width, or there's another element that is pushing out the width, which stops the viewport tag from properly scaling the content to the device. The pull request I submitted fixed it while I was editing through Webkit Inspector on my iPhone, so I must have missed something when implementing. I'll take a look in a bit. Thanks for pulling my attention to this.

@ajpiano
jQuery Foundation member
ajpiano commented Feb 4, 2013

This is also an issue on api.jquery.com and api.jqueryui.com as well. Not sure if there is a generic issue that can be fixed across sites, or if there happens to be the same flaw duplicated in jqueryui.com and api.jquery.com's css/markup. I'm inclined to think the fix for all 3 should be included in 1 fell swoop.

@kleinmaetschke

@ajpiano I commented on the Issue, but I'll relay here, too. The issue on the API sites is the lengthy titles for the API elements. Since they don't word-wrap for obvious reasons, they break the content frame and extend beyond the page. Making the font-size smaller feels inconsistent and becomes almost illegible at the smaller sizes on longer titles. This pull request was intending to be a partial fix, applying only to the jqueryui.com portion of the issue report. The API portions need more thought before fixing.

@ajpiano
jQuery Foundation member
ajpiano commented Feb 4, 2013

Ah, ok. Confused as to why it's happening on the home page of api.jqueryui.com, where there are no long titles to create the issue

@kleinmaetschke

@ajpiano Good point, I had made a poor assumption in my Super Bowl stupor last night. Seems the issue on API.jqueryui.com is the footer navigation, which may be the remaining issue with jqueryui.com as well. You can see where this content pushes past the frame's edge here Will fix soon as I'm able.

@kleinmaetschke

@ajpiano Here's an update that should fix jQueryUI.com and api.jQueryUI.com's width issue on mobile. The long titles issue still remains for api.jquery.com

@ajpiano
jQuery Foundation member
ajpiano commented Feb 6, 2013

3ba3553 aace93d

Thanks @kleinmaetschke. We can deal with api.jquery.com in a separate PR

@ajpiano ajpiano closed this Feb 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.