New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles for figure/figcaption on api.jquery.com #383

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@kswedberg
Member

kswedberg commented Dec 2, 2015

These styles are in preparation for a commit on api.jquery.com (see jquery/api.jquery.com#829)

@jquerybot jquerybot added the CLA: Valid label Dec 2, 2015

@kswedberg

This comment has been minimized.

Show comment
Hide comment
@kswedberg

kswedberg Dec 2, 2015

Member

by the way, this shouldn't have any effect on the site as it is now. Will only affect new markup introduced in commit noted above.

Member

kswedberg commented Dec 2, 2015

by the way, this shouldn't have any effect on the site as it is now. Will only affect new markup introduced in commit noted above.

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Dec 2, 2015

Member

I guess this is good, though we should probably wait for at least one entry to be updated to actually use a figure element.

Member

scottgonzalez commented Dec 2, 2015

I guess this is good, though we should probably wait for at least one entry to be updated to actually use a figure element.

@kswedberg

This comment has been minimized.

Show comment
Hide comment
@kswedberg

kswedberg Dec 2, 2015

Member

They're already there on staging. e.g. http://stage.api.jquery.com/click/

Member

kswedberg commented Dec 2, 2015

They're already there on staging. e.g. http://stage.api.jquery.com/click/

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Dec 2, 2015

Member

Oh, in that case, let's merge!

Member

scottgonzalez commented Dec 2, 2015

Oh, in that case, let's merge!

@kswedberg kswedberg closed this in d2364af Dec 2, 2015

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Dec 2, 2015

Member

Live on staging and production now.

Member

scottgonzalez commented Dec 2, 2015

Live on staging and production now.

@kswedberg

This comment has been minimized.

Show comment
Hide comment
@kswedberg
Member

kswedberg commented Dec 2, 2015

thanks, @scottgonzalez !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment