Permalink
18 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Revert fb44450 which is no longer necessary with the release of Opera…
… 11. Fixes #7608.
- Loading branch information
Showing
1 changed file
with
3 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotta love auto-updating browsers :) What’s up with this commit though? What exactly do you mean by “no longer necessary with the release of Opera 11”? Older versions never existed?
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean you only support the newest Opera in jQuery?
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdalton When you consider browser support you can take into account the conversion rate between versions. If you look at Russia (the biggest userbase of Opera, ~31% of the country uses it) you can see that such version changes go really fast. [1]
It may seem a bit harsh to treat a decent browser like Opera this way, but I guess jQuery decided so. And it's not necessarily bad.
[1] http://gs.statcounter.com/#browser_version-RU-monthly-200912-201012
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@galambalazs: The StatCounter results you’re linking to are flawed. Opera’s David Storey recently tweeted:
However, I agree with your point that it may not matter all that much, since Opera has had auto-updating functionality as of version 9.
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdalton ...and it's not necessarily bad from the market's perspective.
From another point of view
if ( document.defaultView.getComputedStyle )
may be too weak to detect full support, especially if you're aware of caveats (as per Mr Resig's commit @fb44450). Capability AND bug testing is the right way to go in this case. Because there may be no explicit UA sniffing in the code, but to tell you the truth it isn't too far from that.012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathiasbynens - I thought I've deleted that comment, because I wanted to add some more content to it. Now, I have to edit it to make more sense :)
As for the flawed results, the main point here is not Opera's overall usage, rather the trend between version changes (e.g.: 10.5 -> 10.6). And it's quite comforting I think (also cannot be too flawed because 10.5 users seem to be converted into 10.6 users as you can see).
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like it. I know @csnover has been asking for reduced browser support in jQuery for a while. http://forum.jquery.com/topic/drop-official-support-for-firefox-2-safari-3-opera-9-chrome-4
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like it either. Why only support the current version of Opera? Are there any other browsers that jQuery supports in such a manner?
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdalton - I can't comment on that, I haven't reserched those browsers for significance specifically (but note: Firefox has much slower conversion rates).
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has there been any testing to see if this doesn't mess with jQuery mobile? The Presto Core is shared between mobile and desktop...so only supporting the latest version of desktop is going to have some consequences for mobile devices as well (which generally are behind desktop).
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going back to the previous code will break Opera 11, which does not seem like a good idea. Does anyone here have a proposal for a patch that will work better?
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
John said jQuery treats Chrome like this. Always supports stable channel. That said it feels reallly early to drop support for Opera 10.
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmerthvin - I believe there were other patches
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, Opera’s auto-update doesn’t update without user consent (by default). Chrome does it all automatically (provided the user opens and closes the application every now and then). That’s a big difference.
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep. http://help.opera.com/Windows/11.00/en/autoupdate.html
Users can turn it off, or have it configured to do it manually, or tell it to remind them later. Meaning stuff is going to break for them if they don't update within what, 3 weeks since Opera 11 has officially been out?
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this list authoritative? https://gist.github.com/672714#LID164 If so, it says Chrome-1, not current Chrome.
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From #jquery-meeting: "JohnResig: for desktop we should support 11 and 10.6 for now - dropping 10.6 in the next major. For mobile we support Mini and Mobile current"
012f0c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, during today’s jQuery meeting, it was decided that Opera 11 and 10.6 will still be supported in jQuery 1.5. Support for Opera 10.6 will be dropped in the next major release. For mobile, Opera Mini and the current Opera Mobile version will be supported.
Edit: Whoops, looks like @miketaylr had already said that :) Hadn’t refreshed. For some reason, GitHub won’t let me delete this comment. Move along, nothing to see here.