Skip to content

/jquery

Permalink
Browse files
Loading status checks…

Build: Add "browser" keyword for npm

  • Loading branch information
@dmethvin
dmethvin committed Apr 23, 2014
1 parent 1514dca commit 04ddc4a44ba0f3f55829bf544f19c36404064ffc
Unified Split
Showing with 1 addition and 0 deletions.
  1. +1 −0 package.json
1 package.json
View file
@@ -16,6 +16,7 @@
"keywords": [
"jquery",
"javascript",
"browser",

This comment has been minimized.

Sign in to view
Copy link
@markelog

markelog Apr 23, 2014

Member

Spacing problem?

This comment has been minimized.

Sign in to view
Copy link
@markelog

markelog Apr 23, 2014

Member

I think we should use tabs everywhere, right now we use tabs only in .jshintrc, but .jscsrc and package.json use spaces

This comment has been minimized.

Sign in to view
Copy link
@dmethvin

dmethvin Apr 23, 2014

Author Member

Yeah, this file is using spaces rather than tabs. I suspect it's because the release process writes it. Kind of annoying since we use tabs everywhere else. However, it will be rewritten on the next release I guess.

This comment has been minimized.

Sign in to view
Copy link
@mgol

mgol Apr 23, 2014

Member

npm is invasive here, if you do npm install package --save-dev it rewrites the whole file using 2-space indents. That's why most people keep this formatting, otherwise you have to rewrite the file after every such operation which is tedious.

I wish npm respected a surrounding formatting here. Maybe they'd accept a PR for that. ;)

This comment has been minimized.

Sign in to view
Copy link
@markelog

markelog Apr 23, 2014

Member

npm install package --save-dev

Yeah, i know, but i presume inconsistency is worse

However, it will be rewritten on the next release I guess

Great

This comment has been minimized.

Sign in to view
Copy link
@mgol

mgol Apr 23, 2014

Member

npm install package --save-dev

Yeah, i know, but i presume inconsistency is worse

I'm not sure, unless you have a handy editor being able to quickly reformat this mess, using tabs in this file effectively force you out of using these handy npm methods.

This comment has been minimized.

Sign in to view
Copy link
@scottgonzalez

scottgonzalez Apr 23, 2014

Member

I suspect it's because the release process writes it.

jquery-release respects the existing indentation.

I'm not sure, unless you have a handy editor being able to quickly reformat this mess, using tabs in this file effectively force you out of using these handy npm methods.

Indeed. Give in and use spaces for package.json. Resistance is futile.
"library"
],
"bugs": {

0 comments on commit 04ddc4a

Please sign in to comment.
You can’t perform that action at this time.