Skip to content
Permalink
Browse files

Properly resets firingLength when emptying the list. Fixes #13517

  • Loading branch information...
jaubourg committed Feb 27, 2013
1 parent 1b6be73 commit 0618710913f41d7a7f4c095f0edda035e65a887d
Showing with 17 additions and 0 deletions.
  1. +1 −0 src/callbacks.js
  2. +16 −0 test/unit/callbacks.js
@@ -145,6 +145,7 @@ jQuery.Callbacks = function( options ) {
// Remove all callbacks from the list
empty: function() {
list = [];
firingLength = 0;
return this;
},
// Have the list do nothing anymore
@@ -92,6 +92,22 @@ jQuery.each( tests, function( strFlags, resultString ) {
cblist.fire("A");
strictEqual( output, "X", "Firing after disabling" );

// #13517 - Emptying while firing
cblist = jQuery.Callbacks( flags );
cblist.add( cblist.empty );
cblist.add( function() {
ok( false, "not emptied" );
} );
cblist.fire();

// Disabling while firing
cblist = jQuery.Callbacks( flags );
cblist.add( cblist.disable );
cblist.add( function() {
ok( false, "not disabled" );
} );
cblist.fire();

// Basic binding and firing (context, arguments)
output = "X";
cblist = jQuery.Callbacks( flags );

0 comments on commit 0618710

Please sign in to comment.
You can’t perform that action at this time.