Skip to content

Commit

Permalink
Restore display property in fx module after animation is completed.
Browse files Browse the repository at this point in the history
  • Loading branch information
brandonaaron committed Nov 16, 2006
1 parent 6404d6e commit 06c1853
Showing 1 changed file with 12 additions and 8 deletions.
20 changes: 12 additions & 8 deletions src/fx/fx.js
Expand Up @@ -422,6 +422,13 @@ jQuery.extend({

// The styles
var y = z.el.style;

// Store display property
var oldDisplay = jQuery.css(z.el, 'display');
// Set display property to block for animation
y.display = "block";
// Make sure that nothing sneaks out
y.overflow = "hidden";

// Simple function for setting a style value
z.a = function(){
Expand All @@ -432,8 +439,6 @@ jQuery.extend({
jQuery.attr(y, "opacity", z.now); // Let attr handle opacity
else if ( parseInt(z.now) ) // My hate for IE will never die
y[prop] = parseInt(z.now) + "px";

y.display = "block";
};

// Figure out the maximum number to run to
Expand Down Expand Up @@ -488,9 +493,6 @@ jQuery.extend({
z.custom(z.el.orig[prop], 0);
};

// Make sure that nothing sneaks out
y.overflow = "hidden";

// Each step of an animation
z.step = function(firstNum, lastNum){
var t = (new Date()).getTime();
Expand All @@ -513,13 +515,15 @@ jQuery.extend({
if ( done ) {
// Reset the overflow
y.overflow = '';

// Reset the display
y.display = oldDisplay;
if (jQuery.css(z.el, 'display') == 'none')
y.display = 'block';

// Hide the element if the "hide" operation was done
if ( z.o.hide )
y.display = 'none';
// Otherwise reset the display property
else if ( z.o.show )
y.display = '';

// Reset the properties, if the item has been hidden or shown
if ( z.o.hide || z.o.show )
Expand Down

0 comments on commit 06c1853

Please sign in to comment.