Skip to content
Permalink
Browse files

Make sure that the correct context is being passed in for replaceWith…

…(fn). Fixes #5798.
  • Loading branch information
jeresig committed Jan 26, 2010
1 parent 9f17e70 commit 0b3165fd23ba4d240dd72f93d315bb5f7bf970e8
Showing with 16 additions and 0 deletions.
  1. +6 −0 src/manipulation.js
  2. +10 −0 test/unit/manipulation.js
@@ -233,6 +233,12 @@ jQuery.fn.extend({
// this can help fix replacing a parent with child elements
if ( !jQuery.isFunction( value ) ) {
value = jQuery( value ).detach();

} else {
return this.each(function(i) {
var self = jQuery(this), old = self.html();
self.replaceWith( value.call( this, i, old ) );
});
}

return this.each(function() {
@@ -720,6 +720,16 @@ test("replaceWith(String|Element|Array<Element>|jQuery)", function() {

test("replaceWith(Function)", function() {
testReplaceWith(functionReturningObj);

expect(16);

var y = jQuery("#yahoo")[0];

jQuery(y).replaceWith(function(){
equals( this, y, "Make sure the context is coming in correctly." );
});

reset();
})

test("replaceAll(String|Element|Array<Element>|jQuery)", function() {

0 comments on commit 0b3165f

Please sign in to comment.
You can’t perform that action at this time.