There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -4,7 +4,6 @@ | ||
"newcap": false, | ||
"quotmark": "double", | ||
"regexdash": true, | ||
"strict": true, | ||
"trailing": true, | ||
"undef": true, | ||
"unused": true, | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -12,4 +12,9 @@ | ||
* Date: @DATE | ||
*/ | ||
(function( window, undefined ) { | ||
"use strict"; | ||
|
||
// Can't do this because several apps including ASP.NET trace | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
dmethvin
Author
Member
|
||
// the stack via arguments.caller.callee and Firefox dies if | ||
// you try to trace through "use strict" call chains. (#13335) | ||
// Support: Firefox 18+ | ||
//"use strict"; |
6 comments
on commit 0e29775
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just looked but didn't find a ticket for Firefox or Chrome. Not sure if this is anticipated behavior or not, but I agree it messes up adoption of use strict
since you can never know when strictifying your own code will hose something that is called back from it. The big impact seems to be coming from ASP.NET forms and window.onerror
handlers that use the info to generate stack traces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, cool. I've passed it along.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdalton, I showed this issue to @lukehoban last week as well and he sent it along to them as well... hopefully they'll notice how much this is bumming us out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the comments I think it would be " arguments.callee.caller" but not " arguments.caller.callee".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunnylost, nice catch. @rwldrn, any news on this subject?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mzgol wish I could say so, but I haven't heard anything from the MS devs that I consulted with—ill reach out and find out what I can
Should this be a 2.0 concern? This seems like a tooling issue. Is there a Firefox bugzilla issue to track?
I'd hate to see "use strict" avoided. /cc @rwldrn