Permalink
Browse files

Traversing: .not/.filter consistency with non-elements

Fixes gh-2808
Close gh-2809
  • Loading branch information...
1 parent b0b280c commit 0e2f8f9effd2c95647be534bf9055e099aad7cfd @vanderlee vanderlee committed with Timmy Willison Jan 11, 2016
Showing with 12 additions and 1 deletion.
  1. +1 −1 src/traversing/findFilter.js
  2. +11 −0 test/unit/traversing.js
@@ -33,7 +33,7 @@ function winnow( elements, qualifier, not ) {
}
return jQuery.grep( elements, function( elem ) {
- return ( indexOf.call( qualifier, elem ) > -1 ) !== not;
+ return ( indexOf.call( qualifier, elem ) > -1 ) !== not && elem.nodeType === 1;
} );
}
@@ -430,6 +430,17 @@ QUnit.test( "not(jQuery)", function( assert ) {
assert.deepEqual( jQuery( "p" ).not( jQuery( "#ap, #sndp, .result" ) ).get(), q( "firstp", "en", "sap", "first" ), "not(jQuery)" );
} );
+QUnit.test( "not(Selector) excludes non-element nodes (gh-2808)", function( assert ) {
+ assert.expect( 3 );
+
+ var mixedContents = jQuery( "#nonnodes" ).contents(),
+ childElements = q( "nonnodesElement" );
+
+ assert.deepEqual( mixedContents.not( "*" ).get(), [], "not *" );
+ assert.deepEqual( mixedContents.not( "[id=a],[id=b]" ).get(), childElements, "not [id=a],[id=b]" );
+ assert.deepEqual( mixedContents.not( "[id=a],*,[id=b]" ).get(), [], "not [id=a],*,[id=b]" );
+} );
+
QUnit.test( "has(Element)", function( assert ) {
assert.expect( 3 );
var obj, detached, multipleParent;

0 comments on commit 0e2f8f9

Please sign in to comment.