Skip to content
Permalink
Browse files
Build: Enable ESLint one-var rule for var declarations in browser code
Node.js code is written more & more commonly in ES6+ so it doesn't make sense
to enable it there. There are many violations in test code so it's disabled
there as well.

Closes gh-4615

(cherry picked from commit 4a7fc85)
  • Loading branch information
mgol committed Mar 2, 2020
1 parent 5ea844f commit 0fdfdd829000bffc37e4d32683a8881121faa767
Showing 5 changed files with 9 additions and 5 deletions.
@@ -24,6 +24,7 @@
},

"rules": {
"one-var": ["error", {"var": "always"}],
"strict": ["error", "function"]
}
}
@@ -14,6 +14,7 @@
"rules": {
// That is okay for the built version
"no-multiple-empty-lines": "off",
"one-var": "off",

// Sizzle is not compatible with jQuery code style
"no-nested-ternary": "off",
@@ -103,7 +103,7 @@ define( [
// Behavior in IE 9 is more subtle than in newer versions & it passes
// some versions of this test; make sure not to make it pass there!
reliableTrDimensions: function() {
var table, tr, trChild;
var table, tr, trChild, trStyle;
if ( reliableTrDimensionsVal == null ) {
table = document.createElement( "table" );
tr = document.createElement( "tr" );
@@ -118,7 +118,7 @@ define( [
.appendChild( tr )
.appendChild( trChild );

var trStyle = window.getComputedStyle( tr );
trStyle = window.getComputedStyle( tr );
reliableTrDimensionsVal = parseInt( trStyle.height ) > 3;

documentElement.removeChild( table );
@@ -308,11 +308,12 @@ jQuery.event = {

dispatch: function( nativeEvent ) {

// Make a writable jQuery.Event from the native event object
var event = jQuery.event.fix( nativeEvent );

var i, j, ret, matched, handleObj, handlerQueue,
args = new Array( arguments.length ),

// Make a writable jQuery.Event from the native event object
event = jQuery.event.fix( nativeEvent ),

handlers = ( dataPriv.get( this, "events" ) || {} )[ event.type ] || [],
special = jQuery.event.special[ event.type ] || {};

@@ -46,6 +46,7 @@
"brace-style": "off",
"key-spacing": "off",
"camelcase": "off",
"one-var": "off",
"strict": "off",

// Not really too many - waiting for autofix features for these rules

0 comments on commit 0fdfdd8

Please sign in to comment.