Permalink
Browse files

Remove value check from formHook; other elements can use value hook

  • Loading branch information...
timmywil
timmywil committed May 8, 2011
1 parent 90f37aa commit 18b1cf2942cc082c1c97a2ac9bc33ad77f42d775
Showing with 3 additions and 4 deletions.
  1. +0 −3 src/attributes.js
  2. +3 −1 test/unit/attributes.js
@@ -495,9 +495,6 @@ if ( !jQuery.support.getSetAttribute ) {
formHook = jQuery.attrHooks.name = jQuery.attrHooks.value = jQuery.valHooks.button = {
get: function( elem, name ) {
var ret;
if ( name === "value" && !jQuery.nodeName( elem, "button" ) ) {
return elem.getAttribute( name );
}
ret = elem.getAttributeNode( name );
// Return undefined if nodeValue is empty string
return ret && ret.nodeValue !== "" ?
@@ -144,7 +144,7 @@ test("attr(Hash)", function() {
});

test("attr(String, Object)", function() {
expect(58);
expect(59);

var div = jQuery("div").attr("foo", "bar"),
fail = false;
@@ -244,6 +244,8 @@ test("attr(String, Object)", function() {
table.attr("cellspacing", "2");
equals( table[0].cellSpacing, "2", "Check cellspacing is correctly set" );

equals( jQuery("#area1").attr("value"), undefined, "Value attribute retrieved correctly on textarea." );

// for #1070
jQuery("#name").attr("someAttr", "0");
equals( jQuery("#name").attr("someAttr"), "0", "Set attribute to a string of \"0\"" );

0 comments on commit 18b1cf2

Please sign in to comment.