Permalink
Browse files

Getting window dimensions currently fails in Nokia browsers, causing …

…JS error (and consequently making jQuery Mobile fail to render the page). Based on a tip from Ben Nolan, this fix returns window.screen[width|height] if the other attempts at getting window dimensions fail. On mobile at least, it seems to make sense, and on desktop (assuming this issue would ever show up on desktop), this might be better than returning false or undefined.
  • Loading branch information...
scottjehl
scottjehl committed Dec 22, 2010
1 parent 291b1ed commit 18fa1fd9da12fd6a259b422f91b663d9fbdb181e
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/dimensions.js
@@ -36,7 +36,7 @@ jQuery.each([ "Height", "Width" ], function( i, name ) {
if ( jQuery.isWindow( elem ) ) {
// Everyone else use document.documentElement or document.body depending on Quirks vs Standards mode
return elem.document.compatMode === "CSS1Compat" && elem.document.documentElement[ "client" + name ] ||
elem.document.body[ "client" + name ];
elem.document.body[ "client" + name ] || window.screen && window.screen[ name ];

// Get document width or height
} else if ( elem.nodeType === 9 ) {

0 comments on commit 18fa1fd

Please sign in to comment.