Skip to content
Permalink
Browse files

Make sure that the data- import also supports arrays.

  • Loading branch information
jeresig committed Sep 21, 2010
1 parent e7c2d3b commit 1f8a5e4bbc49c244051101765c46bd8f35e2aa32
Showing with 5 additions and 3 deletions.
  1. +1 −1 src/data.js
  2. +4 −2 test/unit/data.js
@@ -2,7 +2,7 @@

var windowData = {},
rnum = /^-?\d+(?:\.\d+)$/,
rbrace = /^{.*}$/;
rbrace = /^(?:{.*}|\[.*\])$/;

jQuery.extend({
cache: {},
@@ -158,7 +158,7 @@ test(".data(String) and .data(String, Object)", function() {
});

test("data-* attributes", function() {
expect(23);
expect(24);
var div = jQuery("<div>"),
child = jQuery("<div data-myobj='old data' data-ignored=\"DOM\"></div>");

@@ -187,6 +187,7 @@ test("data-* attributes", function() {
.attr("data-pointbad", "5..5")
.attr("data-pointbad2", "-.")
.attr("data-badjson", "{123}")
.attr("data-badjson2", "[abc]")
.attr("data-null", "null")
.attr("data-string", "test");

@@ -197,6 +198,7 @@ test("data-* attributes", function() {
equals( child.data('pointbad'), "5..5", "Bad number read from attribute");
equals( child.data('pointbad2'), "-.", "Bad number read from attribute");
equals( child.data('badjson'), "{123}", "Bad number read from attribute");
equals( child.data('badjson2'), "[abc]", "Bad number read from attribute");
equals( child.data('null'), null, "Primitive null read from attribute");
equals( child.data('string'), "test", "Typical string read from attribute");

@@ -219,7 +221,7 @@ test("data-* attributes", function() {
break;
case 3:
equals(jQuery(elem).data("number"), true, "Check number property");
equals(jQuery(elem).data("stuff"), "[2,8]", "Check stuff property");
same(jQuery(elem).data("stuff"), [2,8], "Check stuff property");
break;
default:
ok(false, ["Assertion failed on index ", index, ", with data ", data].join(''));

0 comments on commit 1f8a5e4

Please sign in to comment.
You can’t perform that action at this time.