Skip to content
Permalink
Browse files

Fix #2184 by using the jQuery.clean() function instead of a direct in…

…nerHTML assignment in the clone() function for IE.
  • Loading branch information
davids549 committed Jan 23, 2008
1 parent e7fef85 commit 1faed11e3c0752981d8b01e1272fb3a72272f966
Showing with 15 additions and 5 deletions.
  1. +2 −4 src/core.js
  2. +13 −1 test/unit/core.js
@@ -303,11 +303,9 @@ jQuery.fn = jQuery.prototype = {
// as properties will not be copied (such as the
// the name attribute on an input).
var clone = this.cloneNode(true),
container = document.createElement("div"),
container2 = document.createElement("div");
container = document.createElement("div");
container.appendChild(clone);
container2.innerHTML = container.innerHTML;
return container2.firstChild;
return jQuery.clean([container.innerHTML])[0];
} else
return this.cloneNode(true);
});
@@ -955,11 +955,23 @@ test("find(String)", function() {
});

test("clone()", function() {
expect(4);
expect(20);
ok( 'This is a normal link: Yahoo' == $('#en').text(), 'Assert text for #en' );
var clone = $('#yahoo').clone();
ok( 'Try them out:Yahoo' == $('#first').append(clone).text(), 'Check for clone' );
ok( 'This is a normal link: Yahoo' == $('#en').text(), 'Reassert text for #en' );

var cloneTags = [
"<table/>", "<tr/>", "<td/>", "<div/>",
"<button/>", "<ul/>", "<ol/>", "<li/>",
"<input type='checkbox' />", "<select/>", "<option/>", "<textarea/>",
"<tbody/>", "<thead/>", "<tfoot/>", "<iframe/>"
];
for (var i = 0; i < cloneTags.length; i++) {
var j = $(cloneTags[i]);
equals( j[0].tagName, j.clone()[0].tagName, 'Clone a &lt;' + cloneTags[i].substring(1));
}

// using contents will get comments regular, text, and comment nodes
var cl = $("#nonnodes").contents().clone();
ok( cl.length >= 2, "Check node,textnode,comment clone works (some browsers delete comments on clone)" );

0 comments on commit 1faed11

Please sign in to comment.
You can’t perform that action at this time.