Permalink
Browse files

Attributes: add SVG class manipulation

- Note: support for SVG is limited in jQuery,
  but this is one area where the cost vs benefit ratio
  was acceptable.

Fixes gh-2199
Close gh-2268
  • Loading branch information...
timmywil committed May 6, 2015
1 parent 56bb677 commit 20aaed367f993f3c2aa204183d82d0d73efa114f
Showing with 71 additions and 29 deletions.
  1. +43 −29 src/attributes/classes.js
  2. +28 −0 test/unit/attributes.js
View
@@ -7,16 +7,20 @@ define([
var rclass = /[\t\r\n\f]/g;
function getClass( elem ) {
return elem.getAttribute && elem.getAttribute( "class" ) || "";
}
jQuery.fn.extend({
addClass: function( value ) {
var classes, elem, cur, clazz, j, finalValue,
var classes, elem, cur, curValue, clazz, j, finalValue,
proceed = typeof value === "string" && value,
i = 0,
len = this.length;
if ( jQuery.isFunction( value ) ) {
return this.each(function( j ) {
jQuery( this ).addClass( value.call( this, j, this.className ) );
jQuery( this ).addClass( value.call( this, j, getClass( this ) ) );
});
}
@@ -26,10 +30,9 @@ jQuery.fn.extend({
for ( ; i < len; i++ ) {
elem = this[ i ];
cur = elem.nodeType === 1 && ( elem.className ?
( " " + elem.className + " " ).replace( rclass, " " ) :
" "
);
curValue = getClass( elem );
cur = elem.nodeType === 1 &&
( " " + curValue + " " ).replace( rclass, " " );
if ( cur ) {
j = 0;
@@ -41,8 +44,8 @@ jQuery.fn.extend({
// only assign if different to avoid unneeded rendering.
finalValue = jQuery.trim( cur );
if ( elem.className !== finalValue ) {
elem.className = finalValue;
if ( curValue !== finalValue ) {
elem.setAttribute( "class", finalValue );
}
}
}
@@ -52,26 +55,26 @@ jQuery.fn.extend({
},
removeClass: function( value ) {
var classes, elem, cur, clazz, j, finalValue,
var classes, elem, cur, curValue, clazz, j, finalValue,
proceed = arguments.length === 0 || typeof value === "string" && value,
i = 0,
len = this.length;
if ( jQuery.isFunction( value ) ) {
return this.each(function( j ) {
jQuery( this ).removeClass( value.call( this, j, this.className ) );
jQuery( this ).removeClass( value.call( this, j, getClass( this ) ) );
});
}
if ( proceed ) {
classes = ( value || "" ).match( rnotwhite ) || [];
for ( ; i < len; i++ ) {
elem = this[ i ];
curValue = getClass( elem );
// This expression is here for better compressibility (see addClass)
cur = elem.nodeType === 1 && ( elem.className ?
( " " + elem.className + " " ).replace( rclass, " " ) :
""
);
cur = elem.nodeType === 1 &&
( " " + curValue + " " ).replace( rclass, " " );
if ( cur ) {
j = 0;
@@ -84,8 +87,8 @@ jQuery.fn.extend({
// Only assign if different to avoid unneeded rendering.
finalValue = value ? jQuery.trim( cur ) : "";
if ( elem.className !== finalValue ) {
elem.className = finalValue;
if ( curValue !== finalValue ) {
elem.setAttribute( "class", finalValue );
}
}
}
@@ -104,20 +107,24 @@ jQuery.fn.extend({
if ( jQuery.isFunction( value ) ) {
return this.each(function( i ) {
jQuery( this ).toggleClass(
value.call(this, i, this.className, stateVal), stateVal
value.call( this, i, getClass( this ), stateVal ),
stateVal
);
});
}
return this.each(function() {
var className, i, self, classNames;
if ( type === "string" ) {
// Toggle individual class names
var className,
i = 0,
self = jQuery( this ),
classNames = value.match( rnotwhite ) || [];
i = 0;
self = jQuery( this );
classNames = value.match( rnotwhite ) || [];
while ( ( className = classNames[ i++ ] ) ) {
while ( (className = classNames[ i++ ]) ) {
// Check each className given, space separated list
if ( self.hasClass( className ) ) {
self.removeClass( className );
@@ -128,18 +135,24 @@ jQuery.fn.extend({
// Toggle whole class name
} else if ( value === undefined || type === "boolean" ) {
if ( this.className ) {
className = getClass( this );
if ( className ) {
// store className if set
dataPriv.set( this, "__className__", this.className );
dataPriv.set( this, "__className__", className );
}
// If the element has a class name or if we're passed `false`,
// then remove the whole classname (if there was one, the above saved it).
// Otherwise bring back whatever was previously saved (if anything),
// falling back to the empty string if nothing was stored.
this.className = this.className || value === false ?
"" :
dataPriv.get( this, "__className__" ) || "";
if ( this.setAttribute ) {
this.setAttribute( "class",
className || value === false ?
"" :
dataPriv.get( this, "__className__" ) || ""
);
}
}
});
},
@@ -150,8 +163,9 @@ jQuery.fn.extend({
l = this.length;
for ( ; i < l; i++ ) {
if ( this[i].nodeType === 1 &&
(" " + this[i].className + " ").replace(rclass, " ").indexOf( className ) > -1 ) {
( " " + getClass( this[i] ) + " " ).replace( rclass, " " )
.indexOf( className ) > -1
) {
return true;
}
}
View
@@ -1478,3 +1478,31 @@ test( "Insignificant white space returned for $(option).val() (#14858)", functio
val = jQuery( "<option> test </option>" ).val();
equal( val.length, 4, "insignificant white-space returned for value" );
});
test( "SVG class manipulation (gh-2199)", function() {

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol May 18, 2015

Member

This needs to be disabled in IE 8: #2325

@mgol

mgol May 18, 2015

Member

This needs to be disabled in IE 8: #2325

expect( 12 );
function createSVGElement( nodeName ) {
return document.createElementNS( "http://www.w3.org/2000/svg", nodeName );
}
jQuery.each([
"svg",
"rect",
"g"
], function() {
var elem = jQuery( createSVGElement( this ) );
elem.addClass( "awesome" );
ok( elem.hasClass( "awesome" ), "SVG element (" + this + ") has added class" );
elem.removeClass( "awesome" );
ok( !elem.hasClass( "awesome" ), "SVG element (" + this + ") removes the class" );
elem.toggleClass( "awesome" );
ok( elem.hasClass( "awesome" ), "SVG element (" + this + ") toggles the class on" );
elem.toggleClass( "awesome" );
ok( !elem.hasClass( "awesome" ), "SVG element (" + this + ") toggles the class off" );
});
});

0 comments on commit 20aaed3

Please sign in to comment.