Fix #12411, .removeClass(undefined) is a chaining no-op. Close gh-913.

.removeClass() //removes all classes, as documented .removeClass(window.nonExistentVariable) // removes nothing
jquery · Oct 22, 2012 · 227c49a · Krinkle · Oct 25, 2012 · 227c49a
1 parent 23d125a
commit 227c49a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/attributes.js b/src/attributes.js
@@ -78,7 +78,7 @@ jQuery.fn.extend({
 				jQuery( this ).removeClass( value.call(this, j, this.className) );
 			});
 		}
-		if ( (value && typeof value === "string") || value === undefined ) {
+		if ( (value && typeof value === "string") || !arguments.length ) {
 			removes = ( value || "" ).split( core_rspace );
 
 			for ( i = 0, l = this.length; i < l; i++ ) {

diff --git a/test/unit/attributes.js b/test/unit/attributes.js
@@ -1202,6 +1202,15 @@ test( "removeClass() removes duplicates", function() {
 	ok( !$div.hasClass("x"), "Element with multiple same classes does not escape the wrath of removeClass()" );
 });
 
+test("removeClass(undefined) is a no-op", function() {
+	expect( 1 );
+
+	var $div = jQuery("<div class='base second'></div>");
+	$div.removeClass( undefined );
+
+	ok( $div.hasClass("base") && $div.hasClass("second"), "Element still has classes after removeClass(undefined)" );
+});
+
 var testToggleClass = function(valueObj) {
 	expect( 17 );