Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
5 changed files
with
19 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -223,36 +223,21 @@ jQuery.extend({ | ||
}, | ||
|
||
// List of data converters | ||
// 1) key format is "source_type => destination_type" (spaces required) | ||
// 1) key format is "source_type destination_type" (a single space in-between) | ||
// 2) the catchall symbol "*" can be used for source_type | ||
dataConverters: { | ||
|
||
// Convert anything to text | ||
"* => text": function(data) { | ||
return "" + data; | ||
}, | ||
"* text": window.String, | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
rwaldron
Member
|
||
|
||
// Text to html (no transformation) | ||
"text => html": function(data) { | ||
return data; | ||
}, | ||
"text html": window.String, | ||
|
||
// Evaluate text as a json expression | ||
"text => json": jQuery.parseJSON, | ||
"text json": jQuery.parseJSON, | ||
|
||
// Parse text as xml | ||
"text => xml": function(data) { | ||
var xml, parser; | ||
if ( window.DOMParser ) { // Standard | ||
parser = new DOMParser(); | ||
xml = parser.parseFromString(data,"text/xml"); | ||
} else { // IE | ||
xml = new ActiveXObject("Microsoft.XMLDOM"); | ||
xml.async="false"; | ||
xml.loadXML(data); | ||
} | ||
return xml; | ||
} | ||
"text xml": jQuery.parseXML | ||
} | ||
}, | ||
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why
window.String
instead ofString
? They're reliable globals in the language (not just in the browser API), also whitelisted in JSHint.Or is this to allow better minification? Afaik it can only optimise the host object name that is locally aliased, not the property. So at best this'd become
a.String
.