Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed the issue where getting an empty value was impossible. Fixes #5…

…697.
  • Loading branch information...
commit 261b7efb5f86a5c9a3de8434f3cad858101e4249 1 parent c97e914
@jeresig jeresig authored
Showing with 7 additions and 2 deletions.
  1. +1 −1  src/attributes.js
  2. +6 −1 test/unit/manipulation.js
View
2  src/attributes.js
@@ -164,7 +164,7 @@ jQuery.fn.extend({
var values = jQuery.makeArray(val);
jQuery( "option", this ).each(function() {
- this.selected = jQuery.inArray( this.value || this.text, values ) >= 0;
+ this.selected = jQuery.inArray( this.value, values ) >= 0;
});
if ( !values.length ) {
View
7 test/unit/manipulation.js
@@ -619,7 +619,7 @@ test("clone() on XML nodes", function() {
}
test("val()", function() {
- expect(9);
+ expect(11);
document.getElementById('text1').value = "bla";
equals( jQuery("#text1").val(), "bla", "Check for modified value of input element" );
@@ -641,6 +641,11 @@ test("val()", function() {
equals( jQuery('#option3e').val(), 'no value', 'Call val() on a option element with no value attribute' );
+ equals( jQuery('#option3a').val(), '', 'Call val() on a option element with no value attribute' );
+
+ jQuery('#select3').val("");
+ same( jQuery('#select3').val(), [''], 'Call val() on a multiple="multiple" select' );
+
});
var testVal = function(valueObj) {
Please sign in to comment.
Something went wrong with that request. Please try again.