Permalink
2 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
1 changed file
with
4 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26bdbb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Timmy,
Just a heads up: The two-replace trim that you got rid of was at least partly the result of a monumental "bikeshedding" thread: http://forum.jquery.com/topic/faster-jquery-trim
So you might get people wondering why you decided to make jQuery.trim() "slower."
26bdbb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My favorite part is this... http://forum.jquery.com/topic/faster-jquery-trim#14737000000647377
String.trim
??