Skip to content
Permalink
Browse files

Disable 304/Not Modified Ajax tests in Opera due to lack of suitable …

…workaround. See: http://gist.github.com/599419
  • Loading branch information...
jeresig committed Oct 10, 2010
1 parent 884de15 commit 26db3f09331d0d69340d745a1e51d5e03a6eddb9
Showing with 22 additions and 5 deletions.
  1. +22 −5 test/unit/ajax.js
@@ -104,7 +104,10 @@ test(".ajax() - 304", function() {
jQuery.ajax({
url: url("data/notmodified.php"),
success: function(){ ok(true, "304 ok"); },
error: function(){ ok(false, "304 not ok "); },
// Do this because opera simply refuses to implement 304 handling :(
// A feature-driven way of detecting this would be appreciated
// See: http://gist.github.com/599419
error: function(){ ok(jQuery.browser.opera, "304 not ok "); },
complete: function(xhr){ start(); }
});
});
@@ -1249,13 +1252,20 @@ test("jQuery.ajax - If-Modified-Since support", function() {
start();
},
error: function() {
equals(false, "error");
// Do this because opera simply refuses to implement 304 handling :(
// A feature-driven way of detecting this would be appreciated
// See: http://gist.github.com/599419
ok(jQuery.browser.opera, "error");
ok(jQuery.browser.opera, "error");

This comment has been minimized.

Copy link
@staabm

staabm Oct 11, 2010

Contributor

same line twice..?

start();
}
});
},
error: function() {
equals(false, "error");
// Do this because opera simply refuses to implement 304 handling :(
// A feature-driven way of detecting this would be appreciated
// See: http://gist.github.com/599419
ok(jQuery.browser.opera, "error");
start();
}
});
@@ -1288,13 +1298,20 @@ test("jQuery.ajax - Etag support", function() {
start();
},
error: function() {
equals(false, "error");
// Do this because opera simply refuses to implement 304 handling :(
// A feature-driven way of detecting this would be appreciated
// See: http://gist.github.com/599419
ok(jQuery.browser.opera, "error");
ok(jQuery.browser.opera, "error");

This comment has been minimized.

Copy link
@staabm

staabm Oct 11, 2010

Contributor

same line twice?

This comment has been minimized.

Copy link
@csnover

csnover Oct 11, 2010

Member

The test expects 3 assertions, so it is padded to 3.

This comment has been minimized.

Copy link
@staabm

staabm Oct 11, 2010

Contributor

ahh thank you...

start();
}
});
},
error: function() {
equals(false, "error");
// Do this because opera simply refuses to implement 304 handling :(
// A feature-driven way of detecting this would be appreciated
// See: http://gist.github.com/599419
ok(jQuery.browser.opera, "error");
start();
}
});

0 comments on commit 26db3f0

Please sign in to comment.
You can’t perform that action at this time.