Skip to content
Permalink
Browse files

Fixed a bug in clone where it wouldn't work on an XML node in IE. Als…

…o added unit test for it.
  • Loading branch information
davids549 committed Dec 12, 2007
1 parent c6a44c7 commit 279f77e9609fba62c11a06f8c65221b16f7bc7d4
Showing with 12 additions and 2 deletions.
  1. +1 −1 src/core.js
  2. +11 −1 test/unit/core.js
@@ -290,7 +290,7 @@ jQuery.fn = jQuery.prototype = {
clone: function( events ) {
// Do the clone
var ret = this.map(function(){
if ( jQuery.browser.msie ) {
if ( jQuery.browser.msie && !jQuery.isXMLDoc(this) ) {
// IE copies events bound via attachEvent when
// using cloneNode. Calling detachEvent on the
// clone will also remove the events from the orignal
@@ -864,14 +864,24 @@ test("find(String)", function() {
});

test("clone()", function() {
expect(4);
expect(6);
ok( 'This is a normal link: Yahoo' == $('#en').text(), 'Assert text for #en' );
var clone = $('#yahoo').clone();
ok( 'Try them out:Yahoo' == $('#first').append(clone).text(), 'Check for clone' );
ok( 'This is a normal link: Yahoo' == $('#en').text(), 'Reassert text for #en' );
// using contents will get comments regular, text, and comment nodes
var cl = $("#nonnodes").contents().clone();
ok( cl.length >= 2, "Check node,textnode,comment clone works (some browsers delete comments on clone)" );

stop();
$.get("data/dashboard.xml", function (xml) {
var root = $(xml.documentElement).clone();
$("tab:first", xml).text("origval");
$("tab:first", root).text("cloneval");
equals($("tab:first", xml).text(), "origval", "Check original XML node was correctly set");
equals($("tab:first", root).text(), "cloneval", "Check cloned XML node was correctly set");
start();
});
});

test("is(String)", function() {

0 comments on commit 279f77e

Please sign in to comment.
You can’t perform that action at this time.