Permalink
Browse files

Data: do not include digits when camelCasing

Fixes gh-1751
  • Loading branch information...
timmywil committed May 3, 2015
1 parent a873558 commit 2862a07af640be42711f72ad4abe532349985824
Showing with 7 additions and 6 deletions.
  1. +1 −1 src/core.js
  2. +1 −1 test/unit/core.js
  3. +5 −4 test/unit/data.js
View
@@ -27,7 +27,7 @@ var
// Matches dashed string for camelizing
rmsPrefix = /^-ms-/,
rdashAlpha = /-([\da-z])/gi,
rdashAlpha = /-([a-z])/gi,
// Used by jQuery.camelCase as callback to replace()
fcamelCase = function( all, letter ) {
View
@@ -1503,7 +1503,7 @@ test("jQuery.camelCase()", function() {
"foo-bar": "fooBar",
"foo-bar-baz": "fooBarBaz",
"girl-u-want": "girlUWant",
"the-4th-dimension": "the4thDimension",
"the-4th-dimension": "the-4thDimension",
"-o-tannenbaum": "OTannenbaum",
"-moz-illa": "MozIlla",
"-ms-take": "msTake"
View
@@ -259,14 +259,14 @@ test(".data(object) does not retain references. #13815", function() {
});
test("data-* attributes", function() {
expect( 43 );
expect( 46 );
var prop, i, l, metadata, elem,
obj, obj2, check, num, num2,
parseJSON = jQuery.parseJSON,
div = jQuery("<div>"),
child = jQuery("<div data-myobj='old data' data-ignored=\"DOM\" data-other='test'></div>"),
dummy = jQuery("<div data-myobj='old data' data-ignored=\"DOM\" data-other='test'></div>");
child = jQuery("<div data-myobj='old data' data-ignored=\"DOM\" data-other='test' data-foo-42='boosh'></div>"),
dummy = jQuery("<div data-myobj='old data' data-ignored=\"DOM\" data-other='test' data-foo-42='boosh'></div>");
equal( div.data("attr"), undefined, "Check for non-existing data-attr attribute" );
@@ -283,6 +283,7 @@ test("data-* attributes", function() {
child.appendTo("#qunit-fixture");
equal( child.data("myobj"), "old data", "Value accessed from data-* attribute");
equal( child.data("foo-42"), "boosh", "camelCasing does not affect numbers (#1751)" );
child.data("myobj", "replaced");
equal( child.data("myobj"), "replaced", "Original data overwritten");
@@ -292,7 +293,7 @@ test("data-* attributes", function() {
obj = child.data();
obj2 = dummy.data();
check = [ "myobj", "ignored", "other" ];
check = [ "myobj", "ignored", "other", "foo-42" ];
num = 0;
num2 = 0;

0 comments on commit 2862a07

Please sign in to comment.