Skip to content
Permalink
Browse files
Removed trailing \x0A from version.txt which caused a problem with th…
…e build (at least in `ant`)
  • Loading branch information
ryantenney authored and jeresig committed Oct 11, 2010
1 parent 385ca2a commit 2866f16c09cce43044d721563a7bdbd9170fb494
Showing 1 changed file with 1 addition and 1 deletion.
@@ -1 +1 @@
1.4.3
1.4.3

2 comments on commit 2866f16

@jzaefferer
Copy link
Member

@jzaefferer jzaefferer commented on 2866f16 Oct 11, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We fixed that for jQuery UI with a nested filterchain:

<loadfile failonerror="no" srcFile="../version.txt" property="release.version">
    <filterchain><striplinebreaks/></filterchain>
</loadfile>

That way you can have linebreaks in there and it won't matter to Ant.

@jeresig
Copy link
Member

@jeresig jeresig commented on 2866f16 Oct 11, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - ok. Although I blame my build script (I lost my release-building script so I had to recreate it from scratch - and forgot to include the echo -n that chopped off the newline).

Please sign in to comment.