Permalink
Browse files

Adds post-install grunt hook

  • Loading branch information...
1 parent 7692ae4 commit 286c4d91dde12ba32f4a56273d05374b1cbb79e7 @fat fat committed with rwaldron Jun 19, 2012
Showing with 5 additions and 1 deletion.
  1. +5 −1 package.json
View
@@ -1,6 +1,7 @@
{
"name": "jquery",
"title": "jQuery",
+ "main": "./dist/jquery.js",
"description": "New Wave JavaScript",
"version": "1.8.0pre",
"homepage": "http://jquery.com",
@@ -30,5 +31,8 @@
"grunt": ">=0.3.9",
"testswarm": "0.2.2"
},
- "keywords": []
+ "keywords": [],
+ "scripts": {
+ "postinstall": "./node_modules/grunt/bin/grunt"
+ }
}

7 comments on commit 286c4d9

Member

Krinkle replied Jun 19, 2012

This is causing color codes to show up in the Jenkins console.

Exec:

npm install --color false
COMMIT=${GIT_COMMIT} grunt --no-color

That second command would be obsolete with this in package.json. Is there a way to translate the npm color option to grunt?

Owner

jzaefferer replied Jun 21, 2012

The second command won't be obsolete, as we need that enviroment variable to pass the commit hash. I don't really this what problem this change solves, but has unintended consequences.

@rwldrn any opinion on the matter?

Member

rwaldron replied Jun 21, 2012

@jzaefferer seems unfortunate, because setting "scripts" and its various callback hooks is pretty common - I think this is a deficiency of our system if there are problems.

Owner

jzaefferer replied Jun 21, 2012

"pretty common", right, but does it matter here at all? I don't know how to fix this without reverting, as we can't pass anything from an npm install call to grunt.

Member

rwaldron replied Jun 21, 2012

Then we'll roll it back for now.

@fat sorry, but this is effing up our Jenkins/testswarm setup

Contributor

fat replied Jun 21, 2012

@jzaefferer can't you just pass that --no-color param along... ./node_modules/grunt/bin/grunt --no-color ?

@rwldrn no big deal - would be nice tho

Contributor

fat replied Jun 21, 2012

@jzaefferer ah never mind, miss read the environment variable bit

Please sign in to comment.