Skip to content
Permalink
Browse files

Re-worked the logic for where .selector and .context are added for ID…

… selectors (especially ones that aren't found). Fixes jQuery bug #3833.
  • Loading branch information
jeresig committed Jan 20, 2009
1 parent 7647ceb commit 28a1f022233585cf40ae727d7d8334665a495e61
Showing with 15 additions and 15 deletions.
  1. +10 −14 src/core.js
  2. +5 −1 test/unit/core.js
@@ -47,20 +47,16 @@ jQuery.fn = jQuery.prototype = {
else {
var elem = document.getElementById( match[3] );

// Make sure an element was located
if ( elem ){
// Handle the case where IE and Opera return items
// by name instead of ID
if ( elem.id != match[3] )
return jQuery().find( selector );

// Otherwise, we inject the element directly into the jQuery object
var ret = jQuery( elem );
ret.context = document;
ret.selector = selector;
return ret;
}
selector = [];
// Handle the case where IE and Opera return items
// by name instead of ID
if ( elem && elem.id != match[3] )
return jQuery().find( selector );

// Otherwise, we inject the element directly into the jQuery object
var ret = jQuery( elem || [] );
ret.context = document;
ret.selector = selector;
return ret;
}

// HANDLE: $(expr, [context])
@@ -53,7 +53,7 @@ test("jQuery()", function() {
});

test("selector state", function() {
expect(28);
expect(30);

var test;

@@ -72,6 +72,10 @@ test("selector state", function() {
test = jQuery("#main");
equals( test.selector, "#main", "#main Selector" );
equals( test.context, document, "#main Context" );

test = jQuery("#notfoundnono");
equals( test.selector, "#notfoundnono", "#notfoundnono Selector" );
equals( test.context, document, "#notfoundnono Context" );

test = jQuery("#main", document);
equals( test.selector, "#main", "#main Selector" );

0 comments on commit 28a1f02

Please sign in to comment.
You can’t perform that action at this time.