Fix #13471. $().on(".xyz"...) should avoid later crash.

If the event type is an empty string we end up hanging in .off() which makes for mighty hard debugging. Instead treat it as a no-op. Docs seem clear this is not allowed.
jquery · Feb 26, 2013 · 2bbc3d5860b81e128cd92f865673e10046caac7d · staabm · Feb 26, 2013 · dmethvin
1 parent 31478b9
commit 2bbc3d5860b81e128cd92f865673e10046caac7d
Unified Split

Showing with 21 additions and 0 deletions.

+5 −0 src/event.js

+16 −0 test/unit/event.js
diff --git a/src/event.js b/src/event.js
@@ -66,6 +66,11 @@ jQuery.event = {
 			tmp = rtypenamespace.exec( types[t] ) || [];
 			type = origType = tmp[1];
 			namespaces = ( tmp[2] || "" ).split( "." ).sort();
+  
+
+  
+			// There *must* be a type, no attaching namespace-only handlers
+  
+			if ( !type ) {
+  
+				continue;
+  
+			}
 			// If event changes its type, use the special event handlers for the changed type
 			special = jQuery.event.special[ type ] || {};

diff --git a/test/unit/event.js b/test/unit/event.js
@@ -555,6 +555,22 @@ test("bind(), multi-namespaced events", function() {
 	jQuery("#firstp").trigger("custom");
 });
+  
+test("namespace-only event binding is a no-op", function(){
+  
+	expect(2);
+  
+
+  
+	jQuery("#firstp")
+  
+		.on( ".whoops", function() {
+  
+			ok( false, "called a namespace-only event" );
+  
+		})
+  
+		.on( "whoops", function() {
+  
+			ok( true, "called whoops" );
+  
+		})
+  
+		.trigger("whoops")	// 1
+  
+		.off(".whoops")
+  
+		.trigger("whoops")	// 2
+  
+		.off("whoops");
+  
+});
+  
+
 test("bind(), with same function", function() {
 	expect(2);