Skip to content
Permalink
Browse files

Attempted to fix #6227, not entirely sure if it's a problem as I'm ha…

…ving a hard time reproducing it. Regardless, the change is harmless and potentially even speeds up appendTo, etc. slightly.
  • Loading branch information
jeresig committed Mar 5, 2010
1 parent 9584e90 commit 2c08004f6d4e7f11a875190e132d204a25cb9418
Showing with 10 additions and 2 deletions.
  1. +1 −1 src/manipulation.js
  2. +9 −1 test/unit/manipulation.js
@@ -442,7 +442,7 @@ jQuery.each({
} else {
for ( var i = 0, l = insert.length; i < l; i++ ) {
var elems = (i > 0 ? this.clone(true) : this).get();
jQuery.fn[ original ].apply( jQuery(insert[i]), elems );
jQuery.fn[ original ].call( jQuery(insert[i]), elems );
ret = ret.concat( elems );
}

@@ -376,13 +376,21 @@ test("append(Function) with incoming value", function() {
});

test("appendTo(String|Element|Array&lt;Element&gt;|jQuery)", function() {
expect(14);
expect(16);

var defaultText = 'Try them out:'
jQuery('<b>buga</b>').appendTo('#first');
equals( jQuery("#first").text(), defaultText + 'buga', 'Check if text appending works' );
equals( jQuery('<option value="appendTest">Append Test</option>').appendTo('#select3').parent().find('option:last-child').attr('value'), 'appendTest', 'Appending html options to select element');

reset();
var l = jQuery("#first").children().length + 3;
jQuery("body").map(function(){
return jQuery("<strong></strong><b></b><b></b>").get();
}).appendTo("p");
equals( jQuery("#first").children().length, l, "Make sure the elements were inserted." );
equals( jQuery("#first").children().last()[0].nodeName.toLowerCase(), "b", "Verify the last element." );

reset();
var expected = "This link has class=\"blog\": Simon Willison's WeblogTry them out:";
jQuery(document.getElementById('first')).appendTo('#sap');

2 comments on commit 2c08004

@rkatic

This comment has been minimized.

Copy link
Contributor

rkatic replied Mar 5, 2010

Then why no just:
jQuery( insert[i] ) original ;

@jeresig

This comment has been minimized.

Copy link
Member Author

jeresig replied Mar 5, 2010

@rkatic: Good point, just landed that change: 0a307b3

Please sign in to comment.
You can’t perform that action at this time.