Skip to content
Permalink
Browse files

Made sure that animate callbacks get executed even when no properties…

… are passed in. Fixes #5459.
  • Loading branch information
jeresig committed Nov 7, 2009
1 parent b0fe380 commit 3106039aa89410c9abae9947b2520d9c8e62f8f0
Showing with 17 additions and 1 deletion.
  1. +5 −1 src/fx.js
  2. +12 −0 test/unit/fx.js
@@ -164,6 +164,10 @@ jQuery.fn.extend({
}
});

if ( jQuery.isEmptyObject( prop ) ) {
return optall.complete.call(this);
}

// For JS strict compliance
return true;
});
@@ -427,4 +431,4 @@ if ( jQuery.expr && jQuery.expr.filters ) {
return elem === fn.elem;
}).length;
};
}
}
@@ -67,6 +67,18 @@ test("animate option (queue === false)", function () {
});
*/

test("animate with no properties", function() {
expect(1);

var divs = jQuery("div"), count = 0;

divs.animate({}, function(){
count++;
});

equals( divs.length, count, "Make sure that callback is called for each element in the set." );
});

test("animate duration 0", function() {
expect(7);

0 comments on commit 3106039

Please sign in to comment.
You can’t perform that action at this time.