Skip to content
Permalink
Browse files

fix :hidden selector that was accidentally reverted in previous commi…

…t, also fixed tests for :hidden selector in IE6
  • Loading branch information
brandonaaron committed May 4, 2009
1 parent d72b830 commit 31b573185b7728fa74452fbecc515c6de94640a6
Showing with 3 additions and 2 deletions.
  1. +1 −1 src/selector.js
  2. +2 −1 test/unit/selector.js
@@ -977,7 +977,7 @@ jQuery.expr = Sizzle.selectors;
jQuery.expr[":"] = jQuery.expr.filters;

Sizzle.selectors.filters.hidden = function(elem){
return elem.offsetWidth === 0 || elem.offsetHeight === 0;
return elem.offsetWidth === 0 && elem.offsetHeight === 0;
};

Sizzle.selectors.filters.visible = function(elem){
@@ -364,6 +364,7 @@ test("pseudo (:) selectors", function() {
t( "Is Hidden", "#dl:hidden", ["dl"] );

var $div = jQuery('#nothiddendivchild');
$div.css({ fontSize: 0, lineHeight: 0 });// IE also needs to set font-size and line-height to 0
$div.width(0).height(0);
t( "Is Hidden", '#nothiddendivchild:hidden', ['nothiddendivchild'] );
t( "Is Not Hidden", '#nothiddendivchild:visible', [] );
@@ -376,7 +377,7 @@ test("pseudo (:) selectors", function() {
$div.width(1).height(1);
t( "Is Visible", '#nothiddendivchild:visible', ['nothiddendivchild'] );
t( "Is Not Visible", '#nothiddendivchild:hidden', [] );
$div.width('').height('');
$div.width('').height('').css({ fontSize: '', lineHeight: '' });

t( "Check position filtering", "div#nothiddendiv:eq(0)", ["nothiddendiv"] );
t( "Check position filtering", "div#nothiddendiv:last", ["nothiddendiv"] );

0 comments on commit 31b5731

Please sign in to comment.
You can’t perform that action at this time.