Permalink
Browse files

Deferred: fix memory leak of promise callbacks

Fixes gh-3606
Closes gh-3657
  • Loading branch information...
jbedard authored and gibson042 committed Jun 20, 2017
1 parent 80f1c82 commit 36389288e8c7f2538b5ae7dd6877e81a9a76c644
Showing with 8 additions and 1 deletion.
  1. +8 −1 src/deferred.js
@@ -301,8 +301,15 @@ jQuery.extend( {
// fulfilled_callbacks.disable
tuples[ 3 - i ][ 2 ].disable,
// rejected_handlers.disable
// fulfilled_handlers.disable
tuples[ 3 - i ][ 3 ].disable,
// progress_callbacks.lock
tuples[ 0 ][ 2 ].lock
tuples[ 0 ][ 2 ].lock,
// progress_handlers.lock
tuples[ 0 ][ 3 ].lock
);
}

2 comments on commit 3638928

@Krinkle

This comment has been minimized.

Member

Krinkle replied Jul 18, 2017

Unsure, but it seems either this commit or the one before caused #3732. Alternatively, it may've been triggered by a change in Chrome. Although that seems unlikely since it passed in TestSwarm on Chrome 58 before this commit, and failed afterward (minor Chrome update notwithstanding).

@mgol

This comment has been minimized.

Member

mgol replied Jul 19, 2017

Please sign in to comment.