Skip to content

Commit 364476c

Browse files
authored
Tests: Pass a number of necessary done() calls to assert.async()
It is no longer needed to create `done` wrappers in tests that require multiple async operations to complete. Closes gh-4633
1 parent 721744a commit 364476c

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

test/unit/basic.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ if ( jQuery.ajax ) {
44
QUnit.test( "ajax", function( assert ) {
55
assert.expect( 4 );
66

7-
var done = jQuery.map( new Array( 3 ), function() { return assert.async(); } );
7+
var done = assert.async( 3 );
88

99
jQuery.ajax( {
1010
type: "GET",
1111
url: url( "mock.php?action=name&name=foo" ),
1212
success: function( msg ) {
1313
assert.strictEqual( msg, "bar", "Check for GET" );
14-
done.pop()();
14+
done();
1515
}
1616
} );
1717

@@ -21,14 +21,14 @@ QUnit.test( "ajax", function( assert ) {
2121
data: "name=peter",
2222
success: function( msg ) {
2323
assert.strictEqual( msg, "pan", "Check for POST" );
24-
done.pop()();
24+
done();
2525
}
2626
} );
2727

2828
jQuery( "#first" ).load( url( "name.html" ), function() {
2929
assert.ok( /^ERROR/.test( jQuery( "#first" ).text() ),
3030
"Check if content was injected into the DOM" );
31-
done.pop()();
31+
done();
3232
} );
3333
} );
3434
}

test/unit/ready.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,31 +107,31 @@ QUnit.module( "ready" );
107107

108108
QUnit[ jQuery.when ? "test" : "skip" ]( "jQuery.when(jQuery.ready)", function( assert ) {
109109
assert.expect( 2 );
110-
var done = jQuery.map( new Array( 2 ), function() { return assert.async(); } );
110+
var done = assert.async( 2 );
111111

112112
whenified.then( function() {
113113
assert.ok( jQuery.isReady, "jQuery.when Deferred resolved" );
114-
done.pop()();
114+
done();
115115
} );
116116

117117
jQuery.when( jQuery.ready ).then( function() {
118118
assert.ok( jQuery.isReady, "jQuery.when Deferred resolved" );
119-
done.pop()();
119+
done();
120120
} );
121121
} );
122122

123123
QUnit.test( "Promise.resolve(jQuery.ready)", function( assert ) {
124124
assert.expect( 2 );
125-
var done = jQuery.map( new Array( 2 ), function() { return assert.async(); } );
125+
var done = assert.async( 2 );
126126

127127
promisified.then( function() {
128128
assert.ok( jQuery.isReady, "Native promised resolved" );
129-
done.pop()();
129+
done();
130130
} );
131131

132132
Promise.resolve( jQuery.ready ).then( function() {
133133
assert.ok( jQuery.isReady, "Native promised resolved" );
134-
done.pop()();
134+
done();
135135
} );
136136
} );
137137

0 commit comments

Comments
 (0)