Permalink
Browse files

Event: remove preDispatch hook & simplify "simulate" signature

Closes gh-2358
  • Loading branch information...
markelog committed May 28, 2015
1 parent 0019a46 commit 3655c4e1908cc3ee49487e7e26e8cfca9fe8146d
Showing with 4 additions and 7 deletions.
  1. +4 −7 src/event.js
View
@@ -602,7 +602,7 @@ jQuery.event = {
},
// Piggyback on a donor event to simulate a different one
simulate: function( type, elem, event, bubble ) {
simulate: function( type, elem, event ) {
var e = jQuery.extend(
new jQuery.Event(),
event,
@@ -624,11 +624,8 @@ jQuery.event = {
}
);
if ( bubble ) {
jQuery.event.trigger( e, null, elem );
} else {
jQuery.event.dispatch.call( elem, e );
}
jQuery.event.trigger( e, null, elem );
if ( e.isDefaultPrevented() ) {
event.preventDefault();
}
@@ -771,7 +768,7 @@ if ( !support.focusin ) {
// Attach a single capturing handler on the document while someone wants focusin/focusout
var handler = function( event ) {
jQuery.event.simulate( fix, event.target, jQuery.event.fix( event ), true );
jQuery.event.simulate( fix, event.target, jQuery.event.fix( event ) );
};
jQuery.event.special[ fix ] = {

1 comment on commit 3655c4e

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Jun 5, 2015

Member

For anyone seeing this: despite the commit message, the preDispatch hook will not be removed.

Member

timmywil commented on 3655c4e Jun 5, 2015

For anyone seeing this: despite the commit message, the preDispatch hook will not be removed.

Please sign in to comment.