Skip to content
Permalink
Browse files

Fixes IE7 test suite. Keep the testElement attached and set necessary…

… styles on it to fix the offset with margin test.
  • Loading branch information...
timmywil committed Sep 28, 2011
1 parent 649823d commit 3661835101865b08fae20df7458ba03551b86bc3
Showing with 9 additions and 6 deletions.
  1. +6 −3 src/support.js
  2. +2 −2 test/unit/offset.js
  3. +1 −1 test/unit/support.js
@@ -230,7 +230,6 @@ jQuery.support = (function() {

// Remove the body element we added
testElement.innerHTML = "";
testElementParent.removeChild( testElement );

// Technique from Juriy Zaytsev
// http://thinkweb2.com/projects/prototype/detecting-event-support-without-browser-sniffing/
@@ -255,12 +254,15 @@ jQuery.support = (function() {
}

// Determine fixed-position support early
testElement.style.position = "static";
testElement.style.top = "0px";
testElement.style.marginTop = "1px";
offsetSupport = (function( body, container ) {

var outer, inner, table, td, supports,
bodyMarginTop = parseFloat( body.style.marginTop ) || 0,
ptlm = "position:absolute;top:0;left:0;width:1px;height:1px;",
style = "style='" + ptlm + "margin:0;border:5px solid #000;padding:0;'",
ptlm = "position:absolute;top:0;left:0;width:1px;height:1px;margin:0;",
style = "style='" + ptlm + "border:5px solid #000;padding:0;'",
html = "<div " + style + "><div></div></div>" +
"<table " + style + " cellpadding='0' cellspacing='0'>" +
"<tr><td></td></tr></table>";
@@ -296,6 +298,7 @@ jQuery.support = (function() {
})( testElement, div );

jQuery.extend( support, offsetSupport );
testElementParent.removeChild( testElement );

// Null connected elements to avoid leaks in IE
testElement = fragment = select = opt = body = marginDiv = div = input = null;
@@ -401,8 +401,8 @@ testoffset("scroll", function( jQuery, win ) {
testoffset("body", function( jQuery ) {
expect(2);

equals( jQuery("body").offset().top, 0, "jQuery('#body').offset().top" );
equals( jQuery("body").offset().left, 0, "jQuery('#body').offset().left" );
equals( jQuery("body").offset().top, 1, "jQuery('#body').offset().top" );
equals( jQuery("body").offset().left, 1, "jQuery('#body').offset().left" );
});

test("Chaining offset(coords) returns jQuery object", function() {
@@ -47,7 +47,7 @@ supportIFrameTest( "body background is not lost if set prior to loading jQuery (
}
for ( i in support ) {
if ( !( i in jQuery.support ) ) {
ok = false;
passed = false;
strictEqual( src[ i ], dest[ i ], "Unexpected property: " + i );
}
}

0 comments on commit 3661835

Please sign in to comment.
You can’t perform that action at this time.