Skip to content
Permalink
Browse files

Make sure we use detach instead of remove in replaceWith. Fixes #5785.

  • Loading branch information
jeresig committed Jan 11, 2010
1 parent 366039a commit 36a98b95c2f3f7617ddf51beec7515acf67d98ba
Showing with 11 additions and 2 deletions.
  1. +1 −1 src/manipulation.js
  2. +10 −1 test/unit/manipulation.js
@@ -216,7 +216,7 @@ jQuery.fn.extend({
return this.each(function() {
var next = this.nextSibling, parent = this.parentNode;

jQuery(this).remove();
jQuery(this).detach();

if ( next ) {
jQuery(next).before( value );
@@ -626,7 +626,7 @@ test("insertAfter(String|Element|Array<Element>|jQuery)", function() {
});

var testReplaceWith = function(val) {
expect(14);
expect(16);
jQuery('#yahoo').replaceWith(val( '<b id="replace">buga</b>' ));
ok( jQuery("#replace")[0], 'Replace element with string' );
ok( !jQuery("#yahoo")[0], 'Verify that original element is gone, after string' );
@@ -648,6 +648,15 @@ var testReplaceWith = function(val) {
ok( jQuery("#mark")[0], 'Replace element with set of elements' );
ok( !jQuery("#yahoo")[0], 'Verify that original element is gone, after set of elements' );

reset();
var tmp = jQuery("<div/>").appendTo("body").click(function(){ ok(true, "Newly bound click run." ); });
var y = jQuery('#yahoo').click(function(){ ok(true, "Previously bound click run." ); });
y.replaceWith( tmp );
tmp.click();
y.click();

reset();

var set = jQuery("<div/>").replaceWith(val("<span>test</span>"));
equals( set[0].nodeName.toLowerCase(), "span", "Replace the disconnected node." );
equals( set.length, 1, "Replace the disconnected node." );

0 comments on commit 36a98b9

Please sign in to comment.
You can’t perform that action at this time.