Skip to content
Permalink
Browse files
No ticket: Clean up uglifyjs compress options. Close gh-1382.
(cherry picked from commit e156270)
  • Loading branch information
Krinkle authored and gibson042 committed Oct 15, 2013
1 parent 24e5879 commit 3ca883f863f8c4b3b1153e63ef40a8c2c523d399
Showing 1 changed file with 10 additions and 3 deletions.
@@ -113,10 +113,17 @@ module.exports = function( grunt ) {
ascii_only: true
},
compress: {
hoist_funs: false,
join_vars: false,
properties: true,
dead_code: true,
unsafe: false,
booleans: true,
loops: false,
unused: false
unused: false,
hoist_funs: false,
hoist_vars: false,
if_return: true,
join_vars: true,
warnings: true
}
}
}

4 comments on commit 3ca883f

@timmywil
Copy link
Member

@timmywil timmywil commented on 3ca883f Oct 15, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments on the pull were not yet addressed for this one.

@mgol
Copy link
Member

@mgol mgol commented on 3ca883f Oct 15, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. cc @gibson042

@gibson042
Copy link
Member

@gibson042 gibson042 commented on 3ca883f Oct 16, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This landed prematurely (I forgot to alphabetize), but @Krinkle's "hardcode certain sensible defaults" approach was intentional on #1382.

@timmywil
Copy link
Member

@timmywil timmywil commented on 3ca883f Oct 16, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.