Skip to content
Permalink
Browse files

Use real declaration since that helps gzip: thanks @gibson042.

  • Loading branch information
jaubourg committed Apr 25, 2012
1 parent 245f5a2 commit 42dbc86573a1172157def6fc417f33b69d00c2a5
Showing with 5 additions and 3 deletions.
  1. +5 −3 src/callbacks.js
@@ -93,7 +93,8 @@ jQuery.Callbacks = function( options ) {
// First, we save the current length
var start = list.length;
(function add( args ) {
jQuery.each( args, function( type, arg ) {
jQuery.each( args, function( _, arg ) {
var type;
if ( ( type = jQuery.type(arg) ) === "array" ) {
// Inspect recursively
add( arg );
@@ -119,8 +120,9 @@ jQuery.Callbacks = function( options ) {
// Remove a callback from the list
remove: function() {
if ( list ) {
jQuery.each( arguments, function( _, arg, index ) {
while( ( index = jQuery.inArray( arg, list, index || 0 ) ) > -1 ) {
jQuery.each( arguments, function( _, arg ) {
var index = 0;
while( ( index = jQuery.inArray( arg, list, index ) ) > -1 ) {
list.splice( index, 1 );
// Handle firing indexes
if ( firing ) {

4 comments on commit 42dbc86

@mikesherov

This comment has been minimized.

Copy link
Member

mikesherov replied Apr 25, 2012

We should always use real declarations. Using unused args as var declarations is hacky.

@jaubourg

This comment has been minimized.

Copy link
Member Author

jaubourg replied Apr 25, 2012

\o/ I'm a hacker!

@mikesherov

This comment has been minimized.

Copy link
Member

mikesherov replied Apr 25, 2012

Sorry. I should qualify. I find it hacky. Others may disagree :)

@jaubourg

This comment has been minimized.

Copy link
Member Author

jaubourg replied Apr 25, 2012

;P

Please sign in to comment.
You can’t perform that action at this time.