Skip to content
Permalink
Browse files

Set corresponding property to false when removing boolean attributes.…

… Fixes #9094
  • Loading branch information...
timmywil
timmywil committed May 4, 2011
1 parent 9714442 commit 480b88ca37fb3aff4ba043298a8fb419905d3f21
Showing with 12 additions and 1 deletion.
  1. +6 −0 src/attributes.js
  2. +6 −1 test/unit/attributes.js
@@ -369,6 +369,12 @@ jQuery.extend({
jQuery.attr( elem, name, "" );
elem.removeAttributeNode( elem.getAttributeNode( name ) );
}

// Set corresponding property to false for boolean attributes
name = jQuery.propFix[ name ] || name;
if ( !rinvalidChar.test( name ) && typeof elem[ name ] === "boolean" ) {
elem[ name ] = false;
}
}
},

@@ -405,12 +405,17 @@ test("attr('tabindex', value)", function() {
});

test("removeAttr(String)", function() {
expect(5);
expect(7);
equals( jQuery("#mark").removeAttr( "class" )[0].className, "", "remove class" );
equals( jQuery("#form").removeAttr("id").attr("id"), undefined, "Remove id" );
equals( jQuery("#foo").attr("style", "position:absolute;").removeAttr("style").attr("style"), undefined, "Check removing style attribute" );
equals( jQuery("#form").attr("style", "position:absolute;").removeAttr("style").attr("style"), undefined, "Check removing style attribute on a form" );
equals( jQuery("#fx-test-group").attr("height", "3px").removeAttr("height").css("height"), "1px", "Removing height attribute has no effect on height set with style attribute" );

jQuery("#check1").removeAttr("checked").prop("checked", true).removeAttr("checked");
equals( document.getElementById("check1").checked, false, "removeAttr sets boolean properties to false" );
jQuery("#text1").prop("readOnly", true).removeAttr("readonly");
equals( document.getElementById("text1").readOnly, false, "removeAttr sets boolean properties to false" );
});

test("prop(String, Object)", function() {

0 comments on commit 480b88c

Please sign in to comment.
You can’t perform that action at this time.