Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
jquery event: Fixing event.currentTarget for live().
  • Loading branch information
flesler committed Feb 23, 2009
1 parent 883450b commit 48164ee
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/event.js
Expand Up @@ -577,6 +577,7 @@ function liveHandler( event ){
});

jQuery.each(elems, function(){
event.currentTarget = this.elem;
if ( this.fn.call(this.elem, event, this.fn.data) === false )
return (stop = false);
});
Expand Down
13 changes: 12 additions & 1 deletion test/unit/event.js
Expand Up @@ -489,7 +489,7 @@ test("toggle(Function, Function, ...)", function() {
});

test(".live()/.die()", function() {
expect(46);
expect(49);

var submit = 0, div = 0, livea = 0, liveb = 0;

Expand Down Expand Up @@ -649,6 +649,17 @@ test(".live()/.die()", function() {

// Cleanup
jQuery("span#liveSpan1 a, span#liveSpan1, span#liveSpan2 a, span#liveSpan2").die("click");

// Test this, target and currentTarget are correct
jQuery('span#liveSpan1').live('click', function(e){
equals( this.id, 'liveSpan1', 'Check the this within a live handler' );
equals( e.currentTarget.id, 'liveSpan1', 'Check the event.currentTarget within a live handler' );
equals( e.target.nodeName.toUpperCase(), 'A', 'Check the event.target within a live handler' );
});

jQuery('span#liveSpan1 a').click();

jQuery('span#liveSpan1').die('click');
});

/*
Expand Down

0 comments on commit 48164ee

Please sign in to comment.