Skip to content
Permalink
Browse files

Fix setting value attributes on option elements. Fixes #9071.

  • Loading branch information...
timmywil
timmywil committed May 3, 2011
1 parent 6d2fd57 commit 4ac2fdda2c26e9b64502b9ef50748427bed2f3c6
Showing with 4 additions and 2 deletions.
  1. +1 −1 src/attributes.js
  2. +3 −1 test/unit/attributes.js
@@ -199,7 +199,7 @@ jQuery.fn.extend({
hooks = jQuery.valHooks[ this.nodeName.toLowerCase() ] || jQuery.valHooks[ this.type ];

// If set returns undefined, fall back to normal setting
if ( !hooks || ("set" in hooks && hooks.set( this, val, "value" ) === undefined) ) {
if ( !hooks || !("set" in hooks) || hooks.set( this, val, "value" ) === undefined ) {
this.value = val;
}
});
@@ -447,7 +447,7 @@ test("removeProp(String)", function() {
});

test("val()", function() {
expect(25);
expect(26);

document.getElementById("text1").value = "bla";
equals( jQuery("#text1").val(), "bla", "Check for modified value of input element" );
@@ -513,6 +513,8 @@ test("val()", function() {
var $button = jQuery("<button value='foobar'>text</button>").insertAfter("#button");
equals( $button.val(), "foobar", "Value retrieval on a button does not return innerHTML" );
equals( $button.val("baz").html(), "text", "Setting the value does not change innerHTML" );

equals( jQuery("<option/>").val("test").attr("value"), "test", "Setting value sets the value attribute" );
});

var testVal = function(valueObj) {

0 comments on commit 4ac2fdd

Please sign in to comment.
You can’t perform that action at this time.