Skip to content
Permalink
Browse files

Made .clone(true) also copy over element data. Fixes #4191.

  • Loading branch information
jeresig committed Dec 9, 2009
1 parent f6a0bf6 commit 4b70f006f579fba24a882d80ca67f1971dbb4922
Showing with 7 additions and 8 deletions.
  1. +1 −7 src/manipulation.js
  2. +6 −1 test/unit/manipulation.js
@@ -277,13 +277,7 @@ function cloneCopyEvent(orig, ret) {
return;
}

var events = jQuery.data( orig[i], "events" );

for ( var type in events ) {
for ( var handler in events[ type ] ) {
jQuery.event.add( this, type, events[ type ][ handler ], events[ type ][ handler ].data );
}
}
jQuery.data( this, jQuery.data( orig[i++] ) );
});
}

@@ -549,7 +549,7 @@ test("replaceAll(String|Element|Array<Element>|jQuery)", function() {
});

test("clone()", function() {
expect(28);
expect(30);
equals( 'This is a normal link: Yahoo', jQuery('#en').text(), 'Assert text for #en' );
var clone = jQuery('#yahoo').clone();
equals( 'Try them out:Yahoo', jQuery('#first').append(clone).text(), 'Check for clone' );
@@ -594,6 +594,11 @@ test("clone()", function() {
div = div.clone(true);
equals( div.length, 1, "One element cloned" );
equals( div[0].nodeName.toUpperCase(), "DIV", "DIV element cloned" );

div = jQuery("<div/>").data({ a: true, b: true });
div = div.clone(true);
equals( div.data("a"), true, "Data cloned." );
equals( div.data("b"), true, "Data cloned." );
});

if (!isLocal) {

0 comments on commit 4b70f00

Please sign in to comment.
You can’t perform that action at this time.