Skip to content
Permalink
Browse files

Fixed a loop that only worked in webkit.

  • Loading branch information...
jaubourg unknown
jaubourg authored and unknown committed Dec 20, 2010
1 parent 116c82b commit 56628c7adffb4b5436257255f55e31b85b58aa8f
Showing with 8 additions and 6 deletions.
  1. +8 −6 src/core.js
@@ -800,12 +800,14 @@ jQuery.extend({
deferred = {

// then( f1, f2, ...)
then: function() {
then: function then() {

if ( ! cancelled ) {

var args = arguments,
i,
length,
elem,

This comment has been minimized.

Copy link
@davidmurdoch

davidmurdoch Dec 28, 2010

Contributor

Since elem isn't an element maybe it should be renamed to callback or object?

This comment has been minimized.

Copy link
@jaubourg

jaubourg Dec 28, 2010

Member

Well, it's an element of the arguments array. I could have named it arg... but since there already is an "args".

This comment has been minimized.

Copy link
@davidmurdoch

davidmurdoch Dec 28, 2010

Contributor

You're right. I personally tend to use elem when referring to a DOM element/fragment. When I was glancing at the code and saw elem I forgot what I was looking at. :-)

type,
_fired;

@@ -814,13 +816,13 @@ jQuery.extend({
fired = 0;
}

for ( i in args ) {
i = args[ i ];
type = jQuery.type( i );
for ( i = 0, length = args.length ; i < length ; i++ ) {
elem = args[ i ];
type = jQuery.type( elem );
if ( type === "array" ) {
this.then.apply( this , i );
then.apply( this , elem );
} else if ( type === "function" ) {
callbacks.push( i );
callbacks.push( elem );
}
}

0 comments on commit 56628c7

Please sign in to comment.
You can’t perform that action at this time.