Skip to content
Permalink
Browse files

Fix #12127. IE9/10 checks fall off the box on clone. Close gh-873.

  • Loading branch information...
danielchatfield authored and dmethvin committed Jul 25, 2012
1 parent fffd232 commit 569d064fc93459695cb6eb6fd09e5ba3fda62f03
Showing with 16 additions and 6 deletions.
  1. +1 −0 AUTHORS.txt
  2. +1 −3 src/manipulation.js
  3. +3 −3 src/support.js
  4. +11 −0 test/unit/manipulation.js
@@ -129,3 +129,4 @@ David Benjamin <davidben@mit.edu>
Uri Gilad <antishok@gmail.com>
Chris Faulkner <thefaulkner@gmail.com>
Elijah Manor <elijah.manor@gmail.com>
Daniel Chatfield <chatfielddaniel@googlemail.com>
@@ -455,9 +455,7 @@ function cloneFixAttributes( src, dest ) {
// IE6-8 fails to persist the checked state of a cloned checkbox
// or radio button. Worse, IE6-7 fail to give the cloned element
// a checked appearance if the defaultChecked value isn't also set
if ( src.checked ) {
dest.defaultChecked = dest.checked = src.checked;
}
dest.defaultChecked = dest.checked = src.checked;

// IE6-7 get confused and end up setting the value of a cloned
// checkbox/radio button to an empty string instead of "on"
@@ -15,7 +15,7 @@ jQuery.support = (function() {

// Preliminary tests
div.setAttribute( "className", "t" );
div.innerHTML = " <link/><table></table><a href='/a'>a</a><input type='checkbox'/>";
div.innerHTML = " <link/><table></table><a href='/a'>a</a><input type='checkbox' checked='checked'/>";

all = div.getElementsByTagName("*");
a = div.getElementsByTagName("a")[ 0 ];
@@ -96,8 +96,8 @@ jQuery.support = (function() {
};

// Make sure checked status is properly cloned
input.checked = true;
support.noCloneChecked = input.cloneNode( true ).checked;
input.checked = false;
support.noCloneChecked = !input.cloneNode( true ).checked;

// Make sure that the options inside disabled selects aren't marked as disabled
// (WebKit marks them as disabled)
@@ -1895,3 +1895,14 @@ test("html() - script exceptions bubble (#11743)", function() {
ok( false, "error ignored" );
}, "exception bubbled from remote script" );
});

test("checked state is cloned with clone()", function(){
expect(2);

var elem = jQuery.parseHTML('<input type="checkbox" checked="checked"/>')[0];
elem.checked = false;
equal( jQuery(elem).clone().attr('id','clone')[0].checked, false, 'Checked false state correctly cloned' );
elem = jQuery.parseHTML('<input type="checkbox"/>')[0];
elem.checked = true;
equal( jQuery(elem).clone().attr('id','clone')[0].checked, true, 'Checked true state correctly cloned' );
});

0 comments on commit 569d064

Please sign in to comment.
You can’t perform that action at this time.