Permalink
5 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Add note about deprecation of _removeData and _data
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
- Loading branch information
Showing
1 changed file
with
2 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
570ec3d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we agreed to deprecate those? I don't think they should be deprecated until we have a replacement for
$._data( elem, "events" )
. It's still useful, even though it's private.570ec3d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't agreed on anything, or even discussed it. This is me declaring war on them.
Also,
$._data( elem, "events" )
is not a thing we owe anyone a replacement for...570ec3d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would you suggest viewing the events currently bound on an element, which is absolutely necessary and useful?
570ec3d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At one point, it was suggested to have a
$.events
interface for it, instead of using$._data
.570ec3d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree, but I'd like to politely suggest tabling this discussion because it's not worth having a long drawn out argument on github.