Skip to content
Browse files

Use while loop instead of for

  • Loading branch information...
1 parent 58b4994 commit 57d9dcd4a0c3a56160144b7f468fff6e419fed84 @markelog markelog committed with dmethvin
Showing with 7 additions and 12 deletions.
  1. +7 −12 src/manipulation.js
View
19 src/manipulation.js
@@ -422,16 +422,12 @@ jQuery.extend({
},
buildFragment: function( elems, context, scripts, selection ) {
- var elem, tmp, tag, wrap, j, ll, contains,
- fragment = context.createDocumentFragment(),
+ var elem, tmp, tag, wrap, contains, j,
i = 0,
- l = elems.length,
+ fragment = context.createDocumentFragment(),
nodes = [];
- for ( ; i < l; i++ ) {
- elem = elems[ i ];
-
- if ( elem || elem === 0 ) {
+ while ( ( elem = elems[ i++ ] ) || elem === 0 ) {
@gibson042 jQuery Foundation member

On second thought, this one is a functional change (e.g., jQuery.buildFragment( [ "<li>first</li>", false, "<li>last</li>" ], document )), and should probably be reverted.

@markelog jQuery Foundation member

Just a heads-up: apparently, github does not send notifications to the sender of PR, if commit is commented like that, only now i saw this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
// Add nodes directly
if ( jQuery.type( elem ) === "object" ) {
@@ -465,14 +461,13 @@ jQuery.extend({
// Support: Webkit, IE
tmp.textContent = "";
}
- }
}
// Remove wrapper from fragment
fragment.textContent = "";
- for ( i = 0, l = nodes.length; i < l; i++ ) {
- elem = nodes[ i ];
+ i = 0;
+ while ( (elem = nodes[ i++ ]) ) {
contains = jQuery.contains( elem.ownerDocument, elem );
// #4087 - If origin and destination elements are the same, and this is
@@ -491,9 +486,9 @@ jQuery.extend({
// Capture executables
if ( scripts ) {
- for ( j = 0, ll = tmp.length; j < ll; j++ ) {
- elem = tmp[ j ];
+ j = 0;
+ while ( (elem = tmp[ j++ ]) ) {
if ( rscriptType.test( elem.type || "" ) ) {
core_push.call( scripts, elem );
}

0 comments on commit 57d9dcd

Please sign in to comment.
Something went wrong with that request. Please try again.