Permalink
Show file tree
Hide file tree
5 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Effects: 1.8 Animation Rewrite - thanks @mikesherov and @gibson042
- Loading branch information
Showing
4 changed files
with
618 additions
and
546 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
58ed62e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit introduced 12 failures in the
dimensions
test suite in (all browsers).58ed62e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those timeouts?
58ed62e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, they are not. I linked to the run results and job page above. The failures are assertions, such as "Test negative width ignored (Expected: 30; Result: 0)".
58ed62e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have time to look at it 5 minutes ago, so I was being lazy.
58ed62e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm, I'll dig into it tonight unless @mikesherov beats me to it.