Skip to content

Commit

Permalink
Added test and documentation for filter(Function)
Browse files Browse the repository at this point in the history
  • Loading branch information
jzaefferer committed Jan 1, 2007
1 parent 79f9678 commit 5a6029c
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/jquery/coreTest.js
Expand Up @@ -261,6 +261,7 @@ test("clone()", function() {
test("filter()", function() {
isSet( $("input").filter(":checked").get(), q("radio2", "check1"), "filter(String)" );
isSet( $("p").filter(["#ap", "#sndp"]).get(), q("ap", "sndp"), "filter(Array<String>)" );
isSet( $("p").filter(function(el) { return !$("a", el).length }).get(), q("sndp", "first"), "filter(Function)" );
});

test("not(String)", function() {
Expand Down
25 changes: 23 additions & 2 deletions src/jquery/jquery.js
Expand Up @@ -852,13 +852,34 @@ jQuery.fn = jQuery.prototype = {
*
* @example $("p").filter(".selected")
* @before <p class="selected">Hello</p><p>How are you?</p>
* @result $("p").filter(".selected") == [ <p class="selected">Hello</p> ]
* @result [ <p class="selected">Hello</p> ]
*
* @name filter
* @type jQuery
* @param String expr An expression to search with.
* @cat DOM/Traversing
*/

/**
* Removes all elements from the set of matched elements that do not
* pass the specified filter. This method is used to narrow down
* the results of a search.
*
* The elements to filter are passed as the first argument, their
* index inside the set as the second.
*
* @example $("p").filter(function(element, index) {
* return $("ol", element).length == 0;
* })
* @before <p><ol><li>Hello</li></ol></p><p>How are you?</p>
* @result [ <p>How are you?</p> ]
* @desc Remove all elements that have a child ol element
*
* @name filter
* @type jQuery
* @param Function filter A function to use for filtering
* @cat DOM/Traversing
*/

/**
* Removes all elements from the set of matched elements that do not
Expand All @@ -871,7 +892,7 @@ jQuery.fn = jQuery.prototype = {
*
* @example $("p").filter([".selected", ":first"])
* @before <p>Hello</p><p>Hello Again</p><p class="selected">And Again</p>
* @result $("p").filter([".selected", ":first"]) == [ <p>Hello</p>, <p class="selected">And Again</p> ]
* @result [ <p>Hello</p>, <p class="selected">And Again</p> ]
*
* @name filter
* @type jQuery
Expand Down

0 comments on commit 5a6029c

Please sign in to comment.