Skip to content
Permalink
Browse files

Fixes 4825. jQuery.fn.load: use the jXHR's Promise interface to get t…

…he actual response in case ajaxSettings contains a dataFilter. Unit test added.
  • Loading branch information...
jaubourg committed Jan 11, 2011
1 parent c5c1f18 commit 5a721cf31b142365954a2d71e860534da4536b16
Showing with 25 additions and 5 deletions.
  1. +13 −5 src/ajax.js
  2. +12 −0 test/unit/ajax.js
@@ -61,26 +61,34 @@ jQuery.fn.extend({
type: type,
dataType: "html",
data: params,
complete: function( res, status ) {
// Complete callback (responseText is used internally)
complete: function( jXHR, status, responseText ) {
// Store the response as specified by the jXHR object
responseText = jXHR.responseText;
// If successful, inject the HTML into all the matched elements
if ( status === "success" || status === "notmodified" ) {
if ( jXHR.isResolved() ) {
// #4825: Get the actual response in case
// a dataFilter is present in ajaxSettings
jXHR.done(function( r ) {
responseText = r;
});
// See if a selector was specified
self.html( selector ?
// Create a dummy div to hold the results
jQuery("<div>")
// inject the contents of the document in, removing the scripts
// to avoid any 'Permission Denied' errors in IE
.append(res.responseText.replace(rscript, ""))
.append(responseText.replace(rscript, ""))

// Locate the specified elements
.find(selector) :

// If not, just inject the full result
res.responseText );
responseText );
}

if ( callback ) {
self.each( callback, [res.responseText, status, res] );
self.each( callback, [responseText, status, jXHR] );
}
}
});
@@ -1025,6 +1025,18 @@ test("load(String, Function) - check file with only a script tag", function() {
});
});

test("load(String, Function) - dataFilter in ajaxSettings", function() {
expect(2);
stop();
jQuery.ajaxSetup({ dataFilter: function() { return "Hello World"; } });
var div = jQuery("<div/>").load(url("data/name.html"), function(responseText) {
strictEqual( div.html(), "Hello World" , "Test div was filled with filtered data" );
strictEqual( responseText, "Hello World" , "Test callback receives filtered data" );
jQuery.ajaxSetup({ dataFilter: 0 });
start();
});
});

test("load(String, Object, Function)", function() {
expect(2);
stop();

0 comments on commit 5a721cf

Please sign in to comment.
You can’t perform that action at this time.